totole/LaravelShoppingcart
1
0
Fork 0
mirror of https://github.com/kevin-DL/LaravelShoppingcart.git synced 2026-01-24 07:55:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

Updated incorrect use of ksort(), also fixed unittests

Browse Source
This commit is contained in:
Rob Gloudemans
2013-07-27 09:55:23 +02:00
parent a385410367
commit 042ab7a45a
2 changed files with 13 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/Gloudemans/Shoppingcart/Cart.php
View File

@@ -263,7 +263,9 @@ class Cart {
*/ */
protected function generateRowId($id, $options) protected function generateRowId($id, $options)
{ {
return md5($id . serialize(ksort($options))); ksort($options);
return md5($id . serialize($options));
} }
/** /**

17
tests/CartTest.php
View File

@@ -202,32 +202,35 @@ class CartTest extends TestCase {
Cart::add(1, 'Product 1', 1, 10.00, array('size' => 'large', 'color' => 'red')); Cart::add(1, 'Product 1', 1, 10.00, array('size' => 'large', 'color' => 'red'));
Cart::add(2, 'Product 2', 1, 10.00, array('size' => 'large')); Cart::add(2, 'Product 2', 1, 10.00, array('size' => 'large'));
$row1 = '17351068ba2f30bac8d3ccb1ad94dfe6';
$row2 = '5b9865a287421917623bdcf99f7de904';
$search = Cart::search(array('id' => 1, 'name' => 'Product 1')); $search = Cart::search(array('id' => 1, 'name' => 'Product 1'));
$this->assertEquals($search, array('a308327de59a3e249baabc24a6c29928')); $this->assertEquals($search, array($row1));
$search = Cart::search(array('id' => 2, 'name' => 'Product 1')); $search = Cart::search(array('id' => 2, 'name' => 'Product 1'));
$this->assertFalse($search); $this->assertFalse($search);
$search = Cart::search(array('id' => 2, 'name' => 'Product 2')); $search = Cart::search(array('id' => 2, 'name' => 'Product 2'));
$this->assertEquals($search, array('bb0042610e1c6e8bfd7293bfa1807f82')); $this->assertEquals($search, array($row2));
$search = Cart::search(array('id' => 1, 'price' => 10.00)); $search = Cart::search(array('id' => 1, 'price' => 10.00));
$this->assertEquals($search, array('a308327de59a3e249baabc24a6c29928')); $this->assertEquals($search, array($row1));
$search = Cart::search(array('qty' => 1, 'price' => 10.00)); $search = Cart::search(array('qty' => 1, 'price' => 10.00));
$this->assertEquals($search, array('a308327de59a3e249baabc24a6c29928', 'bb0042610e1c6e8bfd7293bfa1807f82')); $this->assertEquals($search, array($row1, $row2));
$search = Cart::search(array('id' => 2, 'kaas' => 'Product 2')); $search = Cart::search(array('id' => 2, 'kaas' => 'Product 2'));
$this->assertFalse($search); $this->assertFalse($search);
$search = Cart::search(array('id' => 2, 'options' => array('size' => 'large'))); $search = Cart::search(array('id' => 2, 'options' => array('size' => 'large')));
$this->assertEquals($search, array('bb0042610e1c6e8bfd7293bfa1807f82')); $this->assertEquals($search, array($row2));
$search = Cart::search(array('options' => array('size' => 'large'))); $search = Cart::search(array('options' => array('size' => 'large')));
$this->assertEquals($search, array('a308327de59a3e249baabc24a6c29928', 'bb0042610e1c6e8bfd7293bfa1807f82')); $this->assertEquals($search, array($row1, $row2));
$search = Cart::search(array('id' => 1, 'options' => array('color' => 'red'))); $search = Cart::search(array('id' => 1, 'options' => array('color' => 'red')));
$this->assertEquals($search, array('a308327de59a3e249baabc24a6c29928')); $this->assertEquals($search, array($row1));
} }
} }