totole/LaravelShoppingcart
1
0
Fork 0
mirror of https://github.com/kevin-DL/LaravelShoppingcart.git synced 2026-01-24 07:55:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixed weight integration, added testcase, fixed weird readme code example

Browse Source
This commit is contained in:
Patrick Henninger
2019-04-16 12:10:06 +02:00
parent 4d302fb4a2
commit 279e820760
3 changed files with 22 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
README.md
View File

@@ -41,16 +41,16 @@ The shoppingcart gives you the following methods to use:
Adding an item to the cart is really simple, you just use the `add()` method, which accepts a variety of parameters. Adding an item to the cart is really simple, you just use the `add()` method, which accepts a variety of parameters.
In its most basic form you can specify the id, name, quantity, price of the product you'd like to add to the cart. In its most basic form you can specify the id, name, quantity, price and weight of the product you'd like to add to the cart.
```php ```php
Cart::add('293ad', 'Product 1', 1, 9.99); Cart::add('293ad', 'Product 1', 1, 9.99, 550);
``` ```
As an optional fifth parameter you can pass it options, so you can add multiple items with the same id, but with (for instance) a different size. As an optional fifth parameter you can pass it options, so you can add multiple items with the same id, but with (for instance) a different size.
```php ```php
Cart::add('293ad', 'Product 1', 1, 9.99, 'weight' => 550, ['size' => 'large']); Cart::add('293ad', 'Product 1', 1, 9.99, 550, ['size' => 'large']);
``` ```
**The `add()` method will return an CartItem instance of the item you just added to the cart.** **The `add()` method will return an CartItem instance of the item you just added to the cart.**

10
src/Cart.php
View File

@@ -105,11 +105,12 @@ class Cart
* @param mixed $name * @param mixed $name
* @param int|float $qty * @param int|float $qty
* @param float $price * @param float $price
* @param float $weight
* @param array $options * @param array $options
* *
* @return \Gloudemans\Shoppingcart\CartItem * @return \Gloudemans\Shoppingcart\CartItem
*/ */
public function add($id, $name = null, $qty = null, $price = null, array $options = []) public function add($id, $name = null, $qty = null, $price = null, $weight = null, array $options = [])
{ {
if ($this->isMulti($id)) { if ($this->isMulti($id)) {
return array_map(function ($item) { return array_map(function ($item) {
@@ -117,7 +118,7 @@ class Cart
}, $id); }, $id);
} }
$cartItem = $this->createCartItem($id, $name, $qty, $price, $options); $cartItem = $this->createCartItem($id, $name, $qty, $price, $weight, $options);
return $this->addCartItem($cartItem); return $this->addCartItem($cartItem);
} }
@@ -696,11 +697,12 @@ class Cart
* @param mixed $name * @param mixed $name
* @param int|float $qty * @param int|float $qty
* @param float $price * @param float $price
* @param float $weight
* @param array $options * @param array $options
* *
* @return \Gloudemans\Shoppingcart\CartItem * @return \Gloudemans\Shoppingcart\CartItem
*/ */
private function createCartItem($id, $name, $qty, $price, array $options) private function createCartItem($id, $name, $qty, $price, $weight, array $options)
{ {
if ($id instanceof Buyable) { if ($id instanceof Buyable) {
$cartItem = CartItem::fromBuyable($id, $qty ?: []); $cartItem = CartItem::fromBuyable($id, $qty ?: []);
@@ -710,7 +712,7 @@ class Cart
$cartItem = CartItem::fromArray($id); $cartItem = CartItem::fromArray($id);
$cartItem->setQuantity($id['qty']); $cartItem->setQuantity($id['qty']);
} else { } else {
$cartItem = CartItem::fromAttributes($id, $name, $price, null, $options); $cartItem = CartItem::fromAttributes($id, $name, $price, $weight, $options);
$cartItem->setQuantity($qty); $cartItem->setQuantity($qty);
} }

13
tests/CartTest.php
View File

@@ -1149,6 +1149,19 @@ class CartTest extends TestCase
$this->assertEquals(2.50, $cart->tax(2)); // tax of 5 Bucks $this->assertEquals(2.50, $cart->tax(2)); // tax of 5 Bucks
} }
/** @test */
public function it_does_allow_adding_cart_items_with_weight_and_options()
{
// https://github.com/bumbummen99/LaravelShoppingcart/pull/5
$cart = $this->getCart();
$cartItem = $cart->add('293ad', 'Product 1', 1, 9.99, 550, ['size' => 'large']);
$this->assertEquals(550, $cartItem->weight);
$this->assertTrue($cartItem->options->has('size'));
$this->assertEquals('large', $cartItem->options->size);
}
/** /**
* Get an instance of the cart. * Get an instance of the cart.
* *