From a215c63165af79137a7332470fe98ce1ed4470ab Mon Sep 17 00:00:00 2001 From: Patrick Henninger Date: Sat, 29 Aug 2020 22:12:00 +0200 Subject: [PATCH] Style CI --- src/Calculation/DefaultCalculator.php | 2 +- src/Calculation/GrossPrice.php | 2 +- src/CartItem.php | 4 +--- src/Contracts/Calculator.php | 4 ++-- src/Exceptions/InvalidCalculatorException.php | 2 +- 5 files changed, 6 insertions(+), 8 deletions(-) diff --git a/src/Calculation/DefaultCalculator.php b/src/Calculation/DefaultCalculator.php index 4d51503..d95f7a7 100644 --- a/src/Calculation/DefaultCalculator.php +++ b/src/Calculation/DefaultCalculator.php @@ -7,7 +7,7 @@ use Gloudemans\Shoppingcart\Contracts\Calculator; class DefaultCalculator implements Calculator { - static function getAttribute(string $attribute, CartItem $cartItem) + public static function getAttribute(string $attribute, CartItem $cartItem) { $decimals = config('cart.format.decimals', 2); diff --git a/src/Calculation/GrossPrice.php b/src/Calculation/GrossPrice.php index 03bb3c9..92cc219 100644 --- a/src/Calculation/GrossPrice.php +++ b/src/Calculation/GrossPrice.php @@ -7,7 +7,7 @@ use Gloudemans\Shoppingcart\Contracts\Calculator; class GrossPrice implements Calculator { - static function getAttribute(string $attribute, CartItem $cartItem) + public static function getAttribute(string $attribute, CartItem $cartItem) { $decimals = config('cart.format.decimals', 2); diff --git a/src/CartItem.php b/src/CartItem.php index e205401..5d183be 100644 --- a/src/CartItem.php +++ b/src/CartItem.php @@ -402,13 +402,11 @@ class CartItem implements Arrayable, Jsonable } $class = new ReflectionClass(config('cart.calculator', DefaultCalculator::class)); - if (!$class->implementsInterface(Calculator::class)) - { + if (!$class->implementsInterface(Calculator::class)) { throw new InvalidCalculatorException('The configured Calculator seems to be invalid. Calculators have to implement the Calculator Contract.'); } return call_user_func($class->getName().'::getAttribute', $attribute, $this); - } /** diff --git a/src/Contracts/Calculator.php b/src/Contracts/Calculator.php index 170b284..137b1e2 100644 --- a/src/Contracts/Calculator.php +++ b/src/Contracts/Calculator.php @@ -6,5 +6,5 @@ use Gloudemans\Shoppingcart\CartItem; interface Calculator { - static function getAttribute(string $attribute, CartItem $cartItem); -} \ No newline at end of file + public static function getAttribute(string $attribute, CartItem $cartItem); +} diff --git a/src/Exceptions/InvalidCalculatorException.php b/src/Exceptions/InvalidCalculatorException.php index 5416e91..abc5370 100644 --- a/src/Exceptions/InvalidCalculatorException.php +++ b/src/Exceptions/InvalidCalculatorException.php @@ -6,4 +6,4 @@ use RuntimeException; class InvalidCalculatorException extends RuntimeException { -} \ No newline at end of file +}