From 5282ce262bd595ae25032f1fb70b41547c8d2c2c Mon Sep 17 00:00:00 2001 From: Jeevanandam M Date: Wed, 25 May 2016 22:49:11 -0700 Subject: [PATCH] revel/revel#1014 added check for path like ../dir & ./dir for new command --- revel/new.go | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/revel/new.go b/revel/new.go index 7252226..fadf268 100644 --- a/revel/new.go +++ b/revel/new.go @@ -8,6 +8,7 @@ import ( "os" "os/exec" "path/filepath" + "strings" "github.com/revel/revel" ) @@ -111,7 +112,11 @@ func initGoPaths() { func setApplicationPath(args []string) { var err error importPath = args[0] - if filepath.IsAbs(importPath) { + + // revel/revel#1014 validate relative path, we cannot use built-in functions + // since Go import path is valid relative path too. + // so check basic part of the path, which is "." + if filepath.IsAbs(importPath) || strings.HasPrefix(importPath, ".") { errorf("Abort: '%s' looks like a directory. Please provide a Go import path instead.", importPath) }