totole/revel-cmd
1
0
Fork 0
mirror of https://github.com/kevin-DL/revel-cmd.git synced 2026-01-11 18:54:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #112 from nathantchan/stable_controllers

Browse Source 
Sort controllers so that builds are reproducible.
This commit is contained in:
notzippy
2018-01-29 21:27:18 -08:00
committed by GitHub
parent 4c87861642 fc904827cd
commit 6ca1d73b61
1 changed files with 12 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
harness/build.go Executable file → Normal file
View File

@@ -23,6 +23,12 @@ import (
var importErrorPattern = regexp.MustCompile("cannot find package \"([^\"]+)\"") var importErrorPattern = regexp.MustCompile("cannot find package \"([^\"]+)\"")
type ByString []*TypeInfo
func (c ByString) Len() int { return len(c) }
func (c ByString) Swap(i, j int) { c[i], c[j] = c[j], c[i] }
func (c ByString) Less(i, j int) bool { return c[i].String() < c[j].String() }
// Build the app: // Build the app:
// 1. Generate the the main.go file. // 1. Generate the the main.go file.
// 2. Run the appropriate "go build" command. // 2. Run the appropriate "go build" command.
@@ -39,12 +45,16 @@ func Build(buildFlags ...string) (app *App, compileError *revel.Error) {
// Add the db.import to the import paths. // Add the db.import to the import paths.
if dbImportPath, found := revel.Config.String("db.import"); found { if dbImportPath, found := revel.Config.String("db.import"); found {
sourceInfo.InitImportPaths = append(sourceInfo.InitImportPaths, strings.Split(dbImportPath,",")...) sourceInfo.InitImportPaths = append(sourceInfo.InitImportPaths, strings.Split(dbImportPath, ",")...)
} }
// Sort controllers so that file generation is reproducible
controllers := sourceInfo.ControllerSpecs()
sort.Stable(ByString(controllers))
// Generate two source files. // Generate two source files.
templateArgs := map[string]interface{}{ templateArgs := map[string]interface{}{
"Controllers": sourceInfo.ControllerSpecs(), "Controllers": controllers,
"ValidationKeys": sourceInfo.ValidationKeys, "ValidationKeys": sourceInfo.ValidationKeys,
"ImportPaths": calcImportAliases(sourceInfo), "ImportPaths": calcImportAliases(sourceInfo),
"TestSuites": sourceInfo.TestSuites(), "TestSuites": sourceInfo.TestSuites(),