From c580259c07a2cce1c54b8a31d6fef6b14bc52b85 Mon Sep 17 00:00:00 2001 From: Rich Harris Date: Sat, 10 Mar 2018 10:01:42 -0500 Subject: [PATCH 1/2] dont hardcode port --- src/cli/dev.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/cli/dev.ts b/src/cli/dev.ts index 5d2d045..558b536 100644 --- a/src/cli/dev.ts +++ b/src/cli/dev.ts @@ -210,7 +210,7 @@ export default async function dev(port: number) { deferreds.client.promise.then(() => { function restart() { - ports.wait(3000).then(deferreds.server.fulfil); // TODO control port + ports.wait(port).then(deferreds.server.fulfil); } if (proc) { From 7f98d50e1543a0fd631c5c5e51f791dcee5237a2 Mon Sep 17 00:00:00 2001 From: Rich Harris Date: Sat, 10 Mar 2018 10:09:18 -0500 Subject: [PATCH 2/2] treat PORT=xxxx the same as --port xxxx --- src/cli/index.ts | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/cli/index.ts b/src/cli/index.ts index 20ab237..de5b1f1 100755 --- a/src/cli/index.ts +++ b/src/cli/index.ts @@ -17,7 +17,9 @@ const prog = sade('sapper').version(pkg.version); prog.command('dev') .describe('Start a development server') .option('-p, --port', 'Specify a port') - .action(async ({ port }: { port: number }) => { + .action(async (opts: { port: number }) => { + let port = opts.port || +process.env.PORT; + if (port) { if (!await ports.check(port)) { console.log(chalk.bold.red(`> Port ${port} is unavailable`)); @@ -53,7 +55,9 @@ prog.command('build [dest]') prog.command('start [dir]') .describe('Start your app') .option('-p, --port', 'Specify a port') - .action(async (dir = 'build', { port }: { port: number }) => { + .action(async (dir = 'build', opts: { port: number }) => { + let port = opts.port || +process.env.PORT; + const resolved = path.resolve(dir); const server = path.resolve(dir, 'server.js');