From 70fd7038b0d6a7038cca6fb1a144f54139e8a62f Mon Sep 17 00:00:00 2001 From: Rich Harris Date: Thu, 30 Aug 2018 18:38:46 -0400 Subject: [PATCH 1/2] skip webpack annotations when using Rollup --- src/api/build.ts | 2 +- src/api/dev.ts | 6 +++--- src/core/create_manifests.ts | 19 +++++++++++++------ 3 files changed, 17 insertions(+), 10 deletions(-) diff --git a/src/api/build.ts b/src/api/build.ts index 941c126..572685a 100644 --- a/src/api/build.ts +++ b/src/api/build.ts @@ -55,7 +55,7 @@ async function execute(emitter: EventEmitter, { const route_objects = create_routes(); // create app/manifest/client.js and app/manifest/server.js - create_main_manifests({ routes: route_objects }); + create_main_manifests({ bundler, routes: route_objects }); const { client, server, serviceworker } = create_compilers(validate_bundler(bundler), { webpack, rollup }); diff --git a/src/api/dev.ts b/src/api/dev.ts index 301a5e7..b15c377 100644 --- a/src/api/dev.ts +++ b/src/api/dev.ts @@ -124,7 +124,7 @@ class Watcher extends EventEmitter { try { const routes = create_routes(); - create_main_manifests({ routes, dev_port }); + create_main_manifests({ bundler: this.bundler, routes, dev_port }); } catch (err) { this.emit('fatal', { message: err.message @@ -145,11 +145,11 @@ class Watcher extends EventEmitter { }, () => { const routes = create_routes(); - create_main_manifests({ routes, dev_port }); + create_main_manifests({ bundler: this.bundler, routes, dev_port }); try { const routes = create_routes(); - create_main_manifests({ routes, dev_port }); + create_main_manifests({ bundler: this.bundler, routes, dev_port }); } catch (err) { this.emit('error', { message: err.message diff --git a/src/core/create_manifests.ts b/src/core/create_manifests.ts index 8152312..518f692 100644 --- a/src/core/create_manifests.ts +++ b/src/core/create_manifests.ts @@ -5,7 +5,8 @@ import { posixify, write_if_changed } from './utils'; import { dev, locations } from '../config'; import { Page, PageComponent, ServerRoute } from '../interfaces'; -export function create_main_manifests({ routes, dev_port }: { +export function create_main_manifests({ bundler, routes, dev_port }: { + bundler: string, routes: { components: PageComponent[], pages: Page[], server_routes: ServerRoute[] }; dev_port?: number; }) { @@ -14,7 +15,7 @@ export function create_main_manifests({ routes, dev_port }: { const path_to_routes = path.relative(manifest_dir, locations.routes()); - const client_manifest = generate_client(routes, path_to_routes, dev_port); + const client_manifest = generate_client(routes, path_to_routes, bundler, dev_port); const server_manifest = generate_server(routes, path_to_routes); write_if_changed( @@ -48,6 +49,7 @@ export function create_serviceworker_manifest({ routes, client_files }: { function generate_client( routes: { root: PageComponent, components: PageComponent[], pages: Page[], server_routes: ServerRoute[] }, path_to_routes: string, + bundler: string, dev_port?: number ) { const page_ids = new Set(routes.pages.map(page => @@ -61,10 +63,15 @@ function generate_client( import root from '${get_file(path_to_routes, routes.root)}'; import error from '${posixify(`${path_to_routes}/_error.html`)}'; - ${routes.components.map(component => - `const ${component.name} = () => - import(/* webpackChunkName: "${component.name}" */ '${get_file(path_to_routes, component)}');`) - .join('\n')} + ${routes.components.map(component => { + const annotation = bundler === 'webpack' + ? `/* webpackChunkName: "${component.name}" */ ` + : ''; + + const source = get_file(path_to_routes, component); + + return `const ${component.name} = () => import(${annotation}'${source}');`; + }).join('\n')} export const manifest = { ignore: [${server_routes_to_ignore.map(route => route.pattern).join(', ')}], From 7798f8f684d58b666e8d4c4c2f313606012bc0e3 Mon Sep 17 00:00:00 2001 From: Rich Harris Date: Thu, 30 Aug 2018 18:41:37 -0400 Subject: [PATCH 2/2] minor tidy up --- src/api/build.ts | 4 ++-- src/api/dev.ts | 2 +- src/core/create_compilers.ts | 14 +++++++------- 3 files changed, 10 insertions(+), 10 deletions(-) diff --git a/src/api/build.ts b/src/api/build.ts index 572685a..5fa9e6a 100644 --- a/src/api/build.ts +++ b/src/api/build.ts @@ -69,7 +69,7 @@ async function execute(emitter: EventEmitter, { fs.writeFileSync(path.join(dest, 'build.json'), JSON.stringify({ bundler, shimport: bundler === 'rollup' && require('shimport/package.json').version, - assets: client_result.assetsByChunkName + assets: client_result.assets })); const server_stats = await server.compile(); @@ -84,7 +84,7 @@ async function execute(emitter: EventEmitter, { if (serviceworker) { create_serviceworker_manifest({ routes: route_objects, - client_files: client_result.assets.map((file: string) => `client/${file}`) + client_files: client_result.chunks.map((file: string) => `client/${file}`) }); serviceworker_stats = await serviceworker.compile(); diff --git a/src/api/dev.ts b/src/api/dev.ts index b15c377..a904bf2 100644 --- a/src/api/dev.ts +++ b/src/api/dev.ts @@ -280,7 +280,7 @@ class Watcher extends EventEmitter { fs.writeFileSync(path.join(dest, 'build.json'), JSON.stringify({ bundler: this.bundler, shimport: this.bundler === 'rollup' && require('shimport/package.json').version, - assets: result.assetsByChunkName + assets: result.assets }, null, ' ')); const client_files = result.assets.map((file: string) => `client/${file}`); diff --git a/src/core/create_compilers.ts b/src/core/create_compilers.ts index b5ed879..40c99a1 100644 --- a/src/core/create_compilers.ts +++ b/src/core/create_compilers.ts @@ -17,8 +17,8 @@ export class CompileResult { duration: number; errors: CompileError[]; warnings: CompileError[]; - assets: string[]; - assetsByChunkName: Record; + chunks: string[]; + assets: Record; } class RollupResult extends CompileResult { @@ -32,15 +32,15 @@ class RollupResult extends CompileResult { this.errors = compiler.errors.map(munge_rollup_warning_or_error); this.warnings = compiler.warnings.map(munge_rollup_warning_or_error); // TODO emit this as they happen - this.assets = compiler.chunks.map(chunk => chunk.fileName); + this.chunks = compiler.chunks.map(chunk => chunk.fileName); // TODO populate this properly. We don't have namedcompiler. chunks, as in // webpack, but we can have a route -> [chunk] map or something - this.assetsByChunkName = {}; + this.assets = {}; compiler.chunks.forEach(chunk => { if (compiler.input in chunk.modules) { - this.assetsByChunkName.main = chunk.fileName; + this.assets.main = chunk.fileName; } }); @@ -110,8 +110,8 @@ class WebpackResult extends CompileResult { this.duration = info.time; - this.assets = info.assets.map((chunk: { name: string }) => chunk.name); - this.assetsByChunkName = info.assetsByChunkName; + this.chunks = info.assets.map((chunk: { name: string }) => chunk.name); + this.assets = info.assetsByChunkName; } print() {