totole/sapper
1
0
Fork 0
mirror of https://github.com/kevin-DL/sapper.git synced 2026-01-18 13:35:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #371 from sveltejs/show-files-on-error

Browse Source 
show which file is causing an error/warning
This commit is contained in:
Rich Harris
2018-08-23 11:21:04 -04:00
committed by GitHub
parent b1a9be2dc3 32f4a50f25
commit 7f255563a4
2 changed files with 11 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/api/interfaces.ts
View File

@@ -26,8 +26,8 @@ export type InvalidEvent = {
export type BuildEvent = { export type BuildEvent = {
type: string; type: string;
errors: Array<{ message: string, duplicate: boolean }>; errors: Array<{ file: string, message: string, duplicate: boolean }>;
warnings: Array<{ message: string, duplicate: boolean }>; warnings: Array<{ file: string, message: string, duplicate: boolean }>;
duration: number; duration: number;
webpack_stats: any; webpack_stats: any;
} }

16
src/cli/dev.ts
View File

@@ -13,7 +13,7 @@ export function dev(opts: { port: number, open: boolean }) {
watcher.on('ready', (event: events.ReadyEvent) => { watcher.on('ready', (event: events.ReadyEvent) => {
if (first) { if (first) {
console.log(`${colors.bold.cyan(`> Listening on http://localhost:${event.port}`)}`); console.log(colors.bold.cyan(`> Listening on http://localhost:${event.port}`));
if (opts.open) child_process.exec(`open http://localhost:${event.port}`); if (opts.open) child_process.exec(`open http://localhost:${event.port}`);
first = false; first = false;
} }
@@ -35,20 +35,21 @@ export function dev(opts: { port: number, open: boolean }) {
}); });
watcher.on('error', (event: events.ErrorEvent) => { watcher.on('error', (event: events.ErrorEvent) => {
console.log(`${colors.red(`✗ ${event.type}`)}`); console.log(colors.red(`✗ ${event.type}`));
console.log(`${colors.red(event.message)}`); console.log(colors.red(event.message));
}); });
watcher.on('fatal', (event: events.FatalEvent) => { watcher.on('fatal', (event: events.FatalEvent) => {
console.log(`${colors.bold.red(`> ${event.message}`)}`); console.log(colors.bold.red(`> ${event.message}`));
if (event.log) console.log(event.log); if (event.log) console.log(event.log);
}); });
watcher.on('build', (event: events.BuildEvent) => { watcher.on('build', (event: events.BuildEvent) => {
if (event.errors.length) { if (event.errors.length) {
console.log(`${colors.bold.red(`✗ ${event.type}`)}`); console.log(colors.bold.red(`✗ ${event.type}`));
event.errors.filter(e => !e.duplicate).forEach(error => { event.errors.filter(e => !e.duplicate).forEach(error => {
if (error.file) console.log(colors.bold(error.file));
console.log(error.message); console.log(error.message);
}); });
@@ -57,9 +58,10 @@ export function dev(opts: { port: number, open: boolean }) {
console.log(`${hidden} duplicate ${hidden === 1 ? 'error' : 'errors'} hidden\n`); console.log(`${hidden} duplicate ${hidden === 1 ? 'error' : 'errors'} hidden\n`);
} }
} else if (event.warnings.length) { } else if (event.warnings.length) {
console.log(`${colors.bold.yellow(`• ${event.type}`)}`); console.log(colors.bold.yellow(`• ${event.type}`));
event.warnings.filter(e => !e.duplicate).forEach(warning => { event.warnings.filter(e => !e.duplicate).forEach(warning => {
if (warning.file) console.log(colors.bold(warning.file));
console.log(warning.message); console.log(warning.message);
}); });
@@ -72,7 +74,7 @@ export function dev(opts: { port: number, open: boolean }) {
} }
}); });
} catch (err) { } catch (err) {
console.log(`${colors.bold.red(`> ${err.message}`)}`); console.log(colors.bold.red(`> ${err.message}`));
process.exit(1); process.exit(1);
} }
} }