totole/sapper
1
0
Fork 0
mirror of https://github.com/kevin-DL/sapper.git synced 2026-01-20 22:35:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #608 from cudr/preload_return_fix

Browse Source 
Don't crash if preload return empty
This commit is contained in:
Rich Harris
2019-04-27 11:15:14 -04:00
committed by GitHub
parent a89f7b01bb 6bf3dd04dd
commit b089ca42ff
3 changed files with 15 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
runtime/src/server/middleware/get_page_handler.ts
View File

@@ -225,7 +225,7 @@ export function get_page_handler(
props[`level${l++}`] = { props[`level${l++}`] = {
component: part.component, component: part.component,
props: preloaded[i + 1], props: preloaded[i + 1] || {},
segment: segments[i] segment: segments[i]
}; };
} }

5
test/apps/preloading/src/routes/preload-nothing/index.svelte Normal file
View File

@@ -0,0 +1,5 @@
<script context="module">
export function preload() {}
</script>
<h1>Page loaded</h1>

9
test/apps/preloading/test.ts
View File

@@ -37,6 +37,15 @@ describe('preloading', function() {
assert.equal(await title(), 'true'); assert.equal(await title(), 'true');
}); });
it('prevent crash if preload return nothing', async () => {
await page.goto(`${base}/preload-nothing`);
await start();
await wait(50);
assert.equal(await title(), 'Page loaded');
});
it('bails on custom classes returned from preload', async () => { it('bails on custom classes returned from preload', async () => {
await page.goto(`${base}/preload-values/custom-class`); await page.goto(`${base}/preload-values/custom-class`);