mirror of
https://github.com/kevin-DL/services.git
synced 2026-03-12 06:04:59 +00:00
Refactor seen service to use database
This commit is contained in:
@@ -4,8 +4,7 @@ import (
|
||||
"context"
|
||||
"time"
|
||||
|
||||
"github.com/google/uuid"
|
||||
"github.com/micro/services/seen/domain"
|
||||
"gorm.io/gorm"
|
||||
|
||||
"github.com/micro/micro/v3/service/errors"
|
||||
"github.com/micro/micro/v3/service/logger"
|
||||
@@ -22,7 +21,14 @@ var (
|
||||
)
|
||||
|
||||
type Seen struct {
|
||||
Domain *domain.Domain
|
||||
DB *gorm.DB
|
||||
}
|
||||
|
||||
type SeenInstance struct {
|
||||
UserID string `gorm:"uniqueIndex:user_resource"`
|
||||
ResourceID string `gorm:"uniqueIndex:user_resource"`
|
||||
ResourceType string `gorm:"uniqueIndex:user_resource"`
|
||||
Timestamp time.Time
|
||||
}
|
||||
|
||||
// Set a resource as seen by a user. If no timestamp is provided, the current time is used.
|
||||
@@ -44,13 +50,12 @@ func (s *Seen) Set(ctx context.Context, req *pb.SetRequest, rsp *pb.SetResponse)
|
||||
}
|
||||
|
||||
// write the object to the store
|
||||
err := s.Domain.Create(domain.Seen{
|
||||
ID: uuid.New().String(),
|
||||
err := s.DB.Create(SeenInstance{
|
||||
UserID: req.UserId,
|
||||
ResourceID: req.ResourceId,
|
||||
ResourceType: req.ResourceType,
|
||||
Timestamp: req.Timestamp.AsTime(),
|
||||
})
|
||||
}).Error
|
||||
if err != nil {
|
||||
logger.Errorf("Error with store: %v", err)
|
||||
return ErrStore
|
||||
@@ -74,11 +79,11 @@ func (s *Seen) Unset(ctx context.Context, req *pb.UnsetRequest, rsp *pb.UnsetRes
|
||||
}
|
||||
|
||||
// delete the object from the store
|
||||
err := s.Domain.Delete(domain.Seen{
|
||||
err := s.DB.Delete(SeenInstance{}, SeenInstance{
|
||||
UserID: req.UserId,
|
||||
ResourceID: req.ResourceId,
|
||||
ResourceType: req.ResourceType,
|
||||
})
|
||||
}).Error
|
||||
if err != nil {
|
||||
logger.Errorf("Error with store: %v", err)
|
||||
return ErrStore
|
||||
@@ -103,16 +108,18 @@ func (s *Seen) Read(ctx context.Context, req *pb.ReadRequest, rsp *pb.ReadRespon
|
||||
}
|
||||
|
||||
// query the store
|
||||
data, err := s.Domain.Read(req.UserId, req.ResourceType, req.ResourceIds)
|
||||
if err != nil {
|
||||
q := s.DB.Where(SeenInstance{UserID: req.UserId, ResourceType: req.ResourceType})
|
||||
q = q.Where("resource_id IN (?)", req.ResourceIds)
|
||||
var data []SeenInstance
|
||||
if err := q.Find(&data).Error; err != nil {
|
||||
logger.Errorf("Error with store: %v", err)
|
||||
return ErrStore
|
||||
}
|
||||
|
||||
// serialize the response
|
||||
rsp.Timestamps = make(map[string]*timestamppb.Timestamp, len(data))
|
||||
for uid, ts := range data {
|
||||
rsp.Timestamps[uid] = timestamppb.New(ts)
|
||||
for _, i := range data {
|
||||
rsp.Timestamps[i.ResourceID] = timestamppb.New(i.Timestamp)
|
||||
}
|
||||
|
||||
return nil
|
||||
|
||||
@@ -5,20 +5,33 @@ import (
|
||||
"testing"
|
||||
"time"
|
||||
|
||||
"github.com/stretchr/testify/assert"
|
||||
|
||||
"github.com/google/uuid"
|
||||
"github.com/micro/micro/v3/service/store/memory"
|
||||
"github.com/micro/services/seen/domain"
|
||||
"github.com/micro/services/seen/handler"
|
||||
pb "github.com/micro/services/seen/proto"
|
||||
"github.com/stretchr/testify/assert"
|
||||
"google.golang.org/protobuf/types/known/timestamppb"
|
||||
"gorm.io/driver/postgres"
|
||||
"gorm.io/gorm"
|
||||
)
|
||||
|
||||
func newHandler() *handler.Seen {
|
||||
return &handler.Seen{
|
||||
Domain: domain.New(memory.NewStore()),
|
||||
func testHandler(t *testing.T) *handler.Seen {
|
||||
// connect to the database
|
||||
db, err := gorm.Open(postgres.Open("postgresql://postgres@localhost:5433/postgres?sslmode=disable"), &gorm.Config{})
|
||||
if err != nil {
|
||||
t.Fatalf("Error connecting to database: %v", err)
|
||||
}
|
||||
|
||||
// migrate the database
|
||||
if err := db.AutoMigrate(&handler.SeenInstance{}); err != nil {
|
||||
t.Fatalf("Error migrating database: %v", err)
|
||||
}
|
||||
|
||||
// clean any data from a previous run
|
||||
if err := db.Exec("TRUNCATE TABLE seen_instances CASCADE").Error; err != nil {
|
||||
t.Fatalf("Error cleaning database: %v", err)
|
||||
}
|
||||
|
||||
return &handler.Seen{DB: db}
|
||||
}
|
||||
|
||||
func TestSet(t *testing.T) {
|
||||
@@ -63,7 +76,7 @@ func TestSet(t *testing.T) {
|
||||
},
|
||||
}
|
||||
|
||||
h := newHandler()
|
||||
h := testHandler(t)
|
||||
for _, tc := range tt {
|
||||
t.Run(tc.Name, func(t *testing.T) {
|
||||
err := h.Set(context.TODO(), &pb.SetRequest{
|
||||
@@ -79,7 +92,7 @@ func TestSet(t *testing.T) {
|
||||
}
|
||||
func TestUnset(t *testing.T) {
|
||||
// seed some test data
|
||||
h := newHandler()
|
||||
h := testHandler(t)
|
||||
seed := &pb.SetRequest{
|
||||
UserId: uuid.New().String(),
|
||||
ResourceId: uuid.New().String(),
|
||||
@@ -142,7 +155,7 @@ func TestUnset(t *testing.T) {
|
||||
|
||||
func TestRead(t *testing.T) {
|
||||
tn := time.Now()
|
||||
h := newHandler()
|
||||
h := testHandler(t)
|
||||
|
||||
// seed some test data
|
||||
td := []struct {
|
||||
|
||||
Reference in New Issue
Block a user