ldflags issue commit, read more...

This commit is address 1.7 release. RC3 is already out there. It may lead to merge conflict while merging develop branch. Since enhancements are done.
This commit is contained in:
Jeevanandam M
2016-07-21 17:22:15 -07:00
parent 4b9e74e1ea
commit 0e6d8d56a2

View File

@@ -77,7 +77,13 @@ func Build(buildFlags ...string) (app *App, compileError *revel.Error) {
gotten := make(map[string]struct{})
for {
appVersion := getAppVersion()
versionLinkerFlags := fmt.Sprintf("-X %s/app.APP_VERSION \"%s\"", revel.ImportPath, appVersion)
versionLinkerFlags := fmt.Sprintf("-X %s/app.APP_VERSION=%s", revel.ImportPath, appVersion)
// TODO remove version check for versionLinkerFlags after Revel becomes Go min version to go1.5
goVersion, _ := strconv.ParseFloat(runtime.Version()[2:5], 64)
if goVersion < 1.5 {
versionLinkerFlags = fmt.Sprintf("-X %s/app.APP_VERSION \"%s\"", revel.ImportPath, appVersion)
}
flags := []string{
"build",
"-i",